Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Links #82

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Optional Links #82

wants to merge 6 commits into from

Conversation

jolheiser
Copy link

Resolves #32

This PR looks for a non-empty environment variable called GITTY_LINKS to determine whether to print hyperlinks in the terminal.

gitty


gitty-all


One thing I noticed is the longer link for branch names (and probably things like numbers, but I think those might be less common unless a repo is on the edge of new index numbers)
I could do some width-checking shenanigans, but I (personally) didn't think it would be worth the extra code checking.

@muesli muesli added the enhancement New feature or request label Oct 26, 2022
@jolheiser
Copy link
Author

I think the workflow error is because I've updated some deps that may require go 1.17 because of build tag changes.
I've update to 1.17 in this PR if that's okay with you.

@jolheiser
Copy link
Author

Looks like rivo/uniseg update would require Go 1.18, so I've updated accordingly.

@muesli
Copy link
Owner

muesli commented Oct 29, 2022

Looks like rivo/uniseg update would require Go 1.18, so I've updated accordingly.

You're right, already noticed that in other projects as well. Will try this out asap, thanks for the contribution!

Signed-off-by: jolheiser <john.olheiser@gmail.com>

# Conflicts:
#	go.mod
#	go.sum
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional links to external services
2 participants