Add alt output format of slice of predictions #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides an alternative output format. Previously, retrieving
an array of predictions was worst case quadratic time, as each cluster's
observations would have to be compared with the original observations
and then assigned their designated cluster. This commit resolves this
issue by simply returning the already generated internal slice of
predictions from Partition.
---
This is a use case that I have. I need performance and to be able to preserve the original observations order, so I'm sending this as a PR. Totally understand if you don't want to merge this, as it doesn't use your muesli/clusters format.
I wasn't sure on the name (
PartitionPoints
), so feel free to change that (or provide suggestions for a v2).