Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use uniseg.StringWidth #69

Closed
wants to merge 2 commits into from
Closed

perf: use uniseg.StringWidth #69

wants to merge 2 commits into from

Conversation

maaslalani
Copy link

Use uniseg.StringWidth for performance.

@maaslalani
Copy link
Author

NB: We're upgrading from 1.11 to 1.18, which is a sizeable jump.

@maaslalani maaslalani mentioned this pull request Jan 22, 2024
Closed
@meowgorithm meowgorithm mentioned this pull request Jan 22, 2024
Closed
@muesli
Copy link
Owner

muesli commented Jan 24, 2024

Looks good to me, but we should do this across all sub-packages.

@maaslalani maaslalani closed this by deleting the head repository Jan 26, 2024
@mikelorant
Copy link

For reference, the remaining functions have been updated in pull request #71.

@maaslalani
Copy link
Author

Ah sorry looks like this PR closed due to me deleting my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelorant mikelorant mikelorant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maaslalani @muesli @mikelorant