Support for CSS named colors #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh! It's also worth nothing that this was implemented against the new CSS palette in |
meowgorithm
force-pushed
the
named-colors
branch
from
1cc8cd2
to
abe57c9
Compare
muesli
reviewed
Dec 7, 2020
color.go
Outdated
| @@ -91,6 +96,8 @@ func (p Profile) Color(s string) Color { | |||
| var c Color | |||
| if strings.HasPrefix(s, "#") { | |||
| c = RGBColor(s) | |||
| } else if _, ok := palette.CSS.Color(s); ok { | |||
There was a problem hiding this comment.
I think this should be the last resort and we should try and convert the string to an integer first and, if that succeeds, treat it as a regular ANSI color. Not that there's currently a clash, but if someone added "8" as a color name to that palette, it would override the ANSI color. We wouldn't want that.
There was a problem hiding this comment.
Makes sense. Updated.
|
Just out: gamut v0.2.0 😄 |
|
Alright, bumped to Gamut v0.2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for CSS named colors via Gamut, so you can do something like the following (per #29):