Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many requests on signup page #674

Closed
taciturnaxolotl opened this issue Sep 8, 2024 · 3 comments
Closed

Too many requests on signup page #674

taciturnaxolotl opened this issue Sep 8, 2024 · 3 comments
Assignees
Labels
bug Something isn't working effort:1 prio b

Comments

@taciturnaxolotl
Copy link

Hi! I just found this project and love it so far! I keep having an issue with the signup page serving a "too many requests" error after 3-4 page loads after startup; simply restarting the container fixes the issue, but then after 3-4 more page loads it happens again.

System information

  • Instance: https://w.dunkirk.sh/signup
  • Wakapi version: 2.11.2
  • Operating system: Docker with the latest tag from ghcr
  • Database: Postgres hosted locally on the machine

Here's my docker compose; it's super simple and basically the same as the README sample minus the Postgres container.

services:
  wakapi:
    image: ghcr.io/muety/wakapi:latest
    ports:
      - 35555:3000
    restart: always
    environment:
      WAKAPI_DB_TYPE: "postgres"
      WAKAPI_DB_NAME: "usr_wakapi"
      WAKAPI_DB_USER: "usrname"
      WAKAPI_DB_PASSWORD: "xxxx"
      WAKAPI_DB_HOST: "hackclub.app"
      WAKAPI_DB_PORT: "5432"
      ENVIRONMENT: "prod"

Docker container logs:

wakapi-1  | 2024-09-08T18:03:46.329908551Z [INFO ] [request] status=429, method=GET, uri=/signup, duration=47.026µs, bytes=18, addr=172.18.0.1:41306, user=-
@taciturnaxolotl
Copy link
Author

Found the issue lol: security.signup_max_rate / WAKAPI_SIGNUP_MAX_RATE was set to the default of 5/1h. I changed it to 1/1s. I don't think that just loading the page should count against you though.

@muety
Copy link
Owner

muety commented Sep 8, 2024

Hi @kcoderhtml, thanks for bringing this up! I had a look at it and turns out that GET /signup is rate-limited, while POST /signup actually isn't. That's definitely a bug. Will fix it.

@muety muety self-assigned this Sep 8, 2024
@muety muety added bug Something isn't working prio b effort:1 labels Sep 8, 2024
@taciturnaxolotl
Copy link
Author

Thanks!

@muety muety closed this as completed in 39ef066 Sep 8, 2024
Milopadma pushed a commit to Milopadma/wakapi that referenced this issue Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort:1 prio b
Projects
None yet
Development

No branches or pull requests

2 participants