Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecation warnings on Release Action #704

Closed
YC opened this issue Nov 5, 2024 · 5 comments
Closed

Address deprecation warnings on Release Action #704

YC opened this issue Nov 5, 2024 · 5 comments

Comments

@YC
Copy link
Collaborator

YC commented Nov 5, 2024

Noticed

The following actions use a deprecated Node.js version and will be forced to run on node20:
softprops/action-gh-release@v1, dev-drprasad/delete-older-releases@v0.3.2.

For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/


For softprops/action-gh-release, we can upgrade to v2.
https://github.com/softprops/action-gh-release/blob/v2.0.9/action.yml#L64

For dev-drprasad/delete-older-releases, it looks like it's no longer maintained.
@muety Was there a particular reason for introducing this step?


Apologies to those who are watching the project and receiving an empty email, I fat-fingered the Enter key...

@YC YC changed the title Address deprecation warnings on CI Address deprecation warnings on Release Action Nov 5, 2024
@muety
Copy link
Owner

muety commented Nov 5, 2024

Thanks for bringing this up! For the delete-older-releases action: I included it simply to remove old clutter. It's not super important, but I'd still prefer if we could find a way to keep it in. Options include to (a) find an alternative on the marketplace, (b) create an own fork (😐) and, in the worst case, (c) remove it.

@muety
Copy link
Owner

muety commented Nov 17, 2024

Do you wanna give it a go?

YC added a commit that referenced this issue Nov 17, 2024
@YC
Copy link
Collaborator Author

YC commented Nov 17, 2024

I've addressed softprops/action-gh-release.
I'm more in favor of keeping releases, for the history of past release notes and artifacts.
An example where this documentation might help is when performing major version upgrades.

@muety
Copy link
Owner

muety commented Nov 17, 2024

Alright, then let's remove the delete-release task.

@YC YC closed this as completed in 4f1b2d0 Nov 17, 2024
@YC
Copy link
Collaborator Author

YC commented Nov 17, 2024

FYI, I think the MSSQL tests are intermittently failing due to microsoft/mssql-docker#895.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants