Avoid redefining components during rendering #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change avoids the definition of new components in
render()
calls, but instead moved them out into their own components or memoises the definitions.If we didn't do that, React would recreate the state of each of these components on every call, which is a performance issue and could lead to inconsistencies if the components have a state that should be preserved.
Type of change
How Has This Been Tested?
Checklist
I have added tests that prove my fix is effective or that my feature worksAny dependent changes have been merged and published in downstream modulesAdditional context