-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added auth #382 and added footer details #737
Conversation
muhammad-fiaz
commented
Dec 28, 2024
- added sign-in using GitHub auth Need to add a Sign-in Authentication functionality #382
- added footer credits
- improved UI and functionality
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 24 changed files in this pull request and generated no comments.
Files not reviewed (15)
- .env-example: Language not supported
- package.json: Language not supported
- public/sitemap-0.xml: Language not supported
- src/components/ui/Footer.tsx: Language not supported
- src/components/ui/Header.tsx: Evaluated as low risk
- src/app/head.tsx: Evaluated as low risk
- src/app/layout.tsx: Evaluated as low risk
- src/components/sections/ProjectsSection.tsx: Evaluated as low risk
- src/components/content/Hero.tsx: Evaluated as low risk
- src/components/sections/BlogSection.tsx: Evaluated as low risk
- src/components/content/CurrentTimeLineExp.tsx: Evaluated as low risk
- src/components/ui/LinksNav.tsx: Evaluated as low risk
- src/components/ui/NavItem.tsx: Evaluated as low risk
- src/types/index.ts: Evaluated as low risk
- next.config.ts: Evaluated as low risk
Comments suppressed due to low confidence (4)
src/components/utils/AuthAvatar.tsx:63
- The
DropdownItem
has a redundantclassName="text-danger"
attribute. It should be removed to avoid confusion.
<DropdownItem key="signOut" className="text-danger" color="danger" onPress={handleSignOut}>
src/configs/envVars.ts:13
- The error message for missing environment variables could be more informative. Consider including details about the expected value or format.
console.error(`Error: Missing environment variable: ${envVar}`);
pages/api/auth/[...nextauth].ts:1
- Ensure that the new authentication handler is covered by tests to verify the GitHub authentication flow.
import { NextApiRequest, NextApiResponse } from "next";
src/components/ui/MobileMenuNav.tsx:84
- [nitpick] The comment about potentially adding AuthAvatar is not necessary and should be removed to keep the code clean.
{/* Optional: You can add AuthAvatar here if needed */}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 24 changed files in this pull request and generated no comments.
Files not reviewed (15)
- .env-example: Language not supported
- package.json: Language not supported
- public/sitemap-0.xml: Language not supported
- src/components/ui/Footer.tsx: Language not supported
- src/components/ui/Header.tsx: Evaluated as low risk
- src/app/head.tsx: Evaluated as low risk
- src/app/layout.tsx: Evaluated as low risk
- src/components/sections/ProjectsSection.tsx: Evaluated as low risk
- src/components/content/Hero.tsx: Evaluated as low risk
- src/components/sections/BlogSection.tsx: Evaluated as low risk
- src/components/content/CurrentTimeLineExp.tsx: Evaluated as low risk
- src/components/ui/LinksNav.tsx: Evaluated as low risk
- src/components/ui/NavItem.tsx: Evaluated as low risk
- src/types/index.ts: Evaluated as low risk
- next.config.ts: Evaluated as low risk
Comments suppressed due to low confidence (6)
src/components/utils/Credits.tsx:25
- [nitpick] The term 'repo' is informal. It should be changed to 'repository' for clarity.
console.error("Failed to fetch repo stats:", error);
src/components/utils/AuthAvatar.tsx:26
- Setting avatarUrl to an empty string is redundant since the Avatar component won't be rendered when the user is not signed in.
setAvatarUrl(''); // Fallback to empty string
src/configs/envVars.ts:11
- The error message could be more descriptive. Consider providing more context about which environment variable is missing and how to set it.
console.error(`Error: Missing environment variable: ${envVar}`);
src/components/ui/MobileMenuNav.tsx:31
- Add a return type annotation for the MenuIcon component to ensure type safety. Suggested change:
const MenuIcon: React.FC<JSX.IntrinsicElements['svg']> = (props) => {
const MenuIcon = (props: JSX.IntrinsicElements['svg']) => {
src/components/ui/MobileMenuNav.tsx:36
- Add a return type annotation for the CrossIcon component to ensure type safety. Suggested change:
const CrossIcon: React.FC<JSX.IntrinsicElements['svg']> = (props) => {
const CrossIcon = (props: JSX.IntrinsicElements['svg']) => {
src/components/ui/MobileMenuNav.tsx:69
- Dynamically change the aria-label based on the state of isMenuOpen for better accessibility. Suggested change:
aria-label={isMenuOpen ? 'Close menu' : 'Open menu'}
aria-label='Toggle menu'