[Toolbar] Add dense variant #12075
Merged
[Toolbar] Add dense variant #12075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srilman
force-pushed
the
feature/dense_app_bar
branch
3 times, most recently
from
b9f1f6b
to
85902c7
Compare
mbrookes
changed the title
|
Could you also add this to the type definitions? |
|
Sure thing. Just added the type defintion |
oliviertassinari
added
the
component: app bar
oliviertassinari
force-pushed
the
feature/dense_app_bar
branch
from
982036a
to
eb138e0
Compare
oliviertassinari
force-pushed
the
feature/dense_app_bar
branch
from
eb138e0
to
2d201e9
Compare
oliviertassinari
changed the title
oliviertassinari
added
new feature
|
@srilman I have updated the pull request to use the variant property over a boolean. Looking at the specification, there is more variant we might want to support in the future. |
|
@srilman It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
acroyear
pushed a commit
to acroyear/material-ui
that referenced
this pull request
Jul 14, 2018
* Address issue mui#11619. Added option for a dense Toolbar. * Fixed actual errors with page * Added type definitions to toolbar dense feature * ready to be merged
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had this around from another project, so I thought I would create a PR.
Not completely sure if it is necessary to modify Typography to make sure that normal font (for titles and such) are smaller when using the dense Toolbar. It is also something that a user can perform manually.
Closes #11619.