Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Dense" AppBar #11619

Closed
fzaninotto opened this issue May 28, 2018 · 4 comments
Closed

"Dense" AppBar #11619

fzaninotto opened this issue May 28, 2018 · 4 comments
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process

Comments

@fzaninotto
Copy link
Contributor

Material-design defines a "dense" version of the AppBar for Desktop. It makes sense, because the AppBar is generally way too large on Desktop.

The <AppBar> component misses this dense prop.

2018-05-29_0103
@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label May 29, 2018
@tomscholz
Copy link

tomscholz commented May 30, 2018 •
edited
Loading

I'm wondering if the prop should only be available only to the AppBar or also for the Toolbar component

@adeelibr
Copy link
Contributor

Is anyone working on this feature? i'd love to work on it.

@fzaninotto
Copy link
Contributor Author

@adeelibr it seems nobody does, feel free to give it a go!

@adeelibr
Copy link
Contributor

adeelibr commented Jul 5, 2018

@fzaninotto I am going to start working on it from tomorrow. I am already working on this table thing. It's kind of a patch. Anyways i'll do this by tomorrow. :) Cheers.

srilman pushed a commit to srilman/material-ui that referenced this issue Jul 6, 2018
Address issue mui#11619. Added option for a dense Toolbar.
3657555
srilman pushed a commit to srilman/material-ui that referenced this issue Jul 6, 2018
Address issue mui#11619. Added option for a dense Toolbar.
5b600d9
srilman pushed a commit to srilman/material-ui that referenced this issue Jul 6, 2018
Address issue mui#11619. Added option for a dense Toolbar.
273b237
@srilman srilman mentioned this issue Jul 6, 2018
Merged
oliviertassinari pushed a commit to oliviertassinari/material-ui that referenced this issue Jul 14, 2018
@oliviertassinari
Address issue mui#11619. Added option for a dense Toolbar.
7507168
oliviertassinari pushed a commit that referenced this issue Jul 14, 2018
@srilman @oliviertassinari
[Toolbar] Add dense variant (#12075)
57644a1 
* Address issue #11619. Added option for a dense Toolbar.

* Fixed actual errors with page

* Added type definitions to toolbar dense feature

* ready to be merged
acroyear pushed a commit to acroyear/material-ui that referenced this issue Jul 14, 2018
@srilman
[Toolbar] Add dense variant (mui#12075)
376412d 
* Address issue mui#11619. Added option for a dense Toolbar.

* Fixed actual errors with page

* Added type definitions to toolbar dense feature

* ready to be merged
@fzaninotto fzaninotto mentioned this issue Jul 17, 2018
Merged
@macdoni02 macdoni02 mentioned this issue Apr 13, 2022
Open
@snyk-bot snyk-bot mentioned this issue Aug 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fzaninotto @oliviertassinari @adeelibr @tomscholz