Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Fix typescript typings #12173

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 17, 2018

Fixes missing generic argument and onChange not assignable.

@material-ui/lab/Slider typings where not compatible with @material-ui/core@1.3.0.

#12087 would introduce the classkey native.

Fixes missing generic argument and onChange not assignable.
@oliviertassinari oliviertassinari changed the title [Slider]: Fix typescript typings [Slider] Fix typescript typings Jul 18, 2018
@oliviertassinari oliviertassinari added component: slider This is the name of the generic UI component, not the React module! typescript labels Jul 18, 2018
@oliviertassinari oliviertassinari merged commit 9169026 into mui:master Jul 18, 2018
@oliviertassinari
Copy link
Member

@eps1lon Thank you

@eps1lon eps1lon deleted the fix-slider-ts-typings branch July 22, 2018 19:52
eneufeld added a commit to eneufeld/jsonforms that referenced this pull request Jul 24, 2018
The version update pulled in new versions of material-ui.
On of those is mui/material-ui#12173
Removed the autofocus to be compatible with the new typings
edgarmueller pushed a commit to eclipsesource/jsonforms that referenced this pull request Jul 27, 2018
The version update pulled in new versions of material-ui.
On of those is mui/material-ui#12173
Removed the autofocus to be compatible with the new typings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants