Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][Slider] use native input to trigger native events #12087

Closed
wants to merge 2 commits into from
Closed

[WIP][Slider] use native input to trigger native events #12087

wants to merge 2 commits into from

Conversation

sakulstra
Copy link
Contributor

@sakulstra sakulstra commented Jul 8, 2018

Disclaimer
I took a stab at #11990 - it's very WIP and I don't know when I'll find time to continue on this, so feel free to pick it up/help me out with the css/jss part.

In the demo you can see that in theory it works and that we'll probably be able to remove some code as the native range input takes care of some of the logic we manually implemented here. Browser support seems to be sufficient to go for native, but apparently the styling implementations vary between browsers so i'm not quite sure if it's a got idea to rely on the Pseudo classes.

Spec: https://material.io/design/components/sliders.html#usage
Problematic parts

Missing parts:

  • reverse/vertical
  • tick marks for discrete sliders
  • value label

@sakulstra
Copy link
Contributor Author

I didn't come to a satisfying solution, due to limited time + very irregular browser support on the slider front: https://css-tricks.com/sliding-nightmare-understanding-range-input/

@sakulstra sakulstra closed this Aug 1, 2018
@sakulstra sakulstra deleted the native-slider branch August 1, 2018 21:28
@mbrookes
Copy link
Member

mbrookes commented Aug 1, 2018

@sakulstra Thanks for trying! 👍

@zannager zannager added the component: slider This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants