[Slider] Remove visual zero state from thumb #12242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
fix-slider-zero-value-visuals
branch
from
f24fbab
to
5857d54
Compare
|
@eps1lon It does indeed seem the appearance of the Slider has been simplified for v2 of the Material guidelines. Feel free to fix it up in another PR. |
eps1lon
force-pushed
the
fix-slider-zero-value-visuals
branch
from
5857d54
to
15d7b82
Compare
|
Rebased master into PR to fix unrelated CI fail on CI now fails as expected on visual differences. Do I have to update some snapshot somewhere or is this resolved once its merged? |
|
You can also remove the empty |
eps1lon
changed the title
|
|
The spec does not show any visual difference between thumbs at zero and non-zero values. Zero values now allow different thumb colors depending on state (i.e. enabled sliders appeared to be disabled).
eps1lon
force-pushed
the
fix-slider-zero-value-visuals
branch
from
4b73f60
to
892e50d
Compare
|
@mbrookes Although |
mbrookes
approved these changes
Jul 23, 2018
mbrookes
added
the
component: slider
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec does not show any visual difference between thumbs at zero and
non-zero values. Zero values now allow different thumb colors depending
on state (i.e. enabled sliders appeared to be disabled).
The colors are also not following the spec: The tracks should only change opacity after the thumb not color. If the default styling should follow the spec as close as possible I would like to adress this in a future PR.