[Slider] Increase color specification conformance #12245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec only displays two different colors for different states (disabled and not-disabled). Track before and after thumb only varies in opacity.
eps1lon
changed the title
eps1lon
changed the title
mbrookes
approved these changes
Jul 23, 2018
|
@eps1lon Thanks! |
oliviertassinari
added
component: slider
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #12242:
The spec only displays two different colors for different states (disabled and not-disabled). Track before and after thumb only varies in opacity.
The spec specifies an explicit color code with .24 opacity after thumb whereas the Crane theme uses secondary color from the palette with .38 opacity. I'm not sure what the best choice would be. I'm leaning towards using the same approach as the Crane theme but went with the primary color and .24 to be as close to the spec as possible while sticking to the previous color theme.