Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Expand on the JSS and class name generator docs #12447

Merged
merged 3 commits into from
Aug 8, 2018
Merged

[docs] Expand on the JSS and class name generator docs #12447

merged 3 commits into from
Aug 8, 2018

Conversation

atrauzzi
Copy link
Contributor

@atrauzzi atrauzzi commented Aug 8, 2018

First pass, includes:

-Reworked the original problem descriptions to contain more anecdotes and keywords (let me know if I messed anything up, there might be some undesirable repetition)
-Extra symptoms, again, more keyword stuffing ;)
-Information for webpack users

Closes #12435

First pass, includes:

- Reworked a bit of the original problem descriptions to contain more anecdotes and keywords (let me know if I messed anything up there)
- Extra symptoms, again, more keyword stuffing ;)
- Information for webpack users
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 8, 2018
@oliviertassinari oliviertassinari changed the title Expand on the JSS and class name generator docs [docs] Expand on the JSS and class name generator docs Aug 8, 2018
@oliviertassinari oliviertassinari merged commit c937ab0 into mui:master Aug 8, 2018
@oliviertassinari
Copy link
Member

@atrauzzi It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot!

@atrauzzi
Copy link
Contributor Author

atrauzzi commented Aug 8, 2018

Thank you! Definitely encouraged to consider more documentation and if ever I feel brave enough -- code.

(Although TBH, I wouldn't want to meddle, this library is perfectly executed and a proud feat of engineering for the FOSS community.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants