Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input] Use the color from the theme #12458

Merged
merged 1 commit into from
Aug 9, 2018
Merged

[Input] Use the color from the theme #12458

merged 1 commit into from
Aug 9, 2018

Conversation

adeelibr
Copy link
Contributor

@adeelibr adeelibr commented Aug 9, 2018 •
edited by oliviertassinari
Loading

Closes #12355

@adeelibr adeelibr mentioned this pull request Aug 9, 2018
Closed
2 tasks
@adeelibr
Copy link
Contributor Author

adeelibr commented Aug 9, 2018

I know you have recommended me to not work on easy issues, but I felt a bit rusty since I have not been active. I am looking for more challenging issues, so going through the issues at the moment. Will tackle something big next time. Thank you. :)

@oliviertassinari oliviertassinari changed the title input hard coded color removed [Input] Use the color from the theme Aug 9, 2018
@oliviertassinari oliviertassinari added new feature New feature or request component: text field This is the name of the generic UI component, not the React module! labels Aug 9, 2018
oliviertassinari
oliviertassinari approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. Nobody picked it up. Better have the issue closed than waiting forever :).
Let me know if you need some guidance for another issue.

@oliviertassinari oliviertassinari merged commit 184b1f5 into mui:master Aug 9, 2018
@adeelibr
Copy link
Contributor Author

@oliviertassinari i'll let you know if I need help when I get stuck. I have picked out the issues that i'll work on.
#12438
#11675

@adeelibr adeelibr deleted the input-color branch May 30, 2019 11:24
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
This was referenced Mar 26, 2020
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adeelibr @oliviertassinari