Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve typescript issue assistance #12560

Merged
merged 4 commits into from
Aug 18, 2018

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 17, 2018

Since the number of issues with typescript is quite significant I decided to ask for useful informations in the issue template.

Especially now with the release of typescript 3 I expect more issues that are hard to replicate without knowing typescript version and the used tsconfig.

There was already a useful codesandbox template which isn't working at the moment but is fixed with this PR.
master: https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/create-react-app-with-typescript
PR: https://codesandbox.io/s/github/eps1lon/material-ui/tree/typescript-issues/examples/create-react-app-with-typescript

Since all of these changes are closely related to one another I decided to bundle these. Just let me know if I should file these separately or squash etc.

eps1lon and others added 4 commits August 17, 2018 07:19
Typescript pulls types from parent directories (which means types used
in core). This currently leads to a ts error along the line of
"cannot simultaneously extends types X and Y".
See also microsoft/TypeScript#11363
@oliviertassinari oliviertassinari changed the title [docs] improve typescript issue assistance [docs] Improve typescript issue assistance Aug 17, 2018
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants