Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve typescript issue assistance #12560

Merged
merged 4 commits into from
Aug 18, 2018
Merged

[docs] Improve typescript issue assistance #12560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
013bf86
[docs] add additional information for ts users to issue template
eps1lon Aug 17, 2018
79967c2
[docs] fix "Could not find entry" in typescript codesandbox
eps1lon Aug 17, 2018
23e0c3f
[docs] fix conflicting types issue for local development of examples
eps1lon Aug 17, 2018
da97085
Typescript -> TypeScript
oliviertassinari Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/ISSUE_TEMPLATE/1.bug.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ about: Create a bug report for Material-UI
This codesandbox.io template _may_ be a good starting point:
https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/create-react-app

If you're using typescript a better starting point would be
https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/create-react-app-with-typescript

If YOU DO NOT take time to provide a codesandbox.io reproduction, should the COMMUNITY take time to help you?

Expand All @@ -50,11 +52,15 @@ Link:
-->

## Your Environment
<!--- Include as many relevant details about the environment with which you experienced the bug. -->
<!---
Include as many relevant details about the environment with which you experienced the bug.
If you encounter issues with typescript please include version and tsconfig.
-->

| Tech | Version |
|--------------|---------|
| Material-UI | v1.?.? |
| React | |
| browser | |
| Browser | |
| TypeScript | |
| etc. | |
1 change: 1 addition & 0 deletions examples/create-react-app-with-typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "create-react-app-with-typescript",
"version": "0.1.0",
"private": true,
"main": "src/index.tsx",
"dependencies": {
"@material-ui/core": "latest",
"@types/react": "*",
Expand Down
1 change: 1 addition & 0 deletions examples/create-react-app-with-typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"jsx": "react",
"moduleResolution": "node",
"rootDir": "src",
"types": [],
"forceConsistentCasingInFileNames": true,
"noImplicitReturns": true,
"noImplicitThis": true,
Expand Down