Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[field] Label doesn't blur unlinked input on mouse down #586

Open
oliviertassinari opened this issue Sep 5, 2024 · 2 comments
Open

[field] Label doesn't blur unlinked input on mouse down #586

oliviertassinari opened this issue Sep 5, 2024 · 2 comments
Assignees
Labels
bug 🐛 Something doesn't work component: field status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 5, 2024

Steps to reproduce

Steps:

  1. https://deploy-preview-477--base-ui.netlify.app/base-ui/react-field/#controlled-validity / https://master--base-ui.netlify.app/components/react-field/#realtime-and-async-validation
Screen.Recording.2024-09-05.at.22.32.52.mov

Current behavior

Doesn't blur on mouse down

Expected behavior

Should blue on mouse down

Screen.Recording.2024-09-05.at.22.37.49.mov

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label

Context

I noticed this on #477. It got me a bit confused at first, I wasn't sure I clicked right when I didn't saw the input blurred, or it made me feel a bit like the UI is unresponsive.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer component: field bug 🐛 Something doesn't work labels Sep 5, 2024
@oliviertassinari oliviertassinari changed the title [field] Doesn't blur input on click [field] Doesn't blur input on mouse down Sep 5, 2024
@atomiks atomiks changed the title [field] Doesn't blur input on mouse down [field] Label doesn't blur unlinked input on mouse down Sep 6, 2024
@atomiks
Copy link
Contributor

atomiks commented Sep 6, 2024

I much prefer that it doesn't blur the label's own/linked input, which always felt strange to me. However I guess unrelated/unliked ones should still blur

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 11, 2024

I guess unrelated/unliked ones should still blur

💯

I much prefer that it doesn't blur the label's own/linked input, which always felt strange to me.

Tricky, it feels like the UI is lagging if I don't see the input blur when I mouse down on something else.

https://mui.com/material-ui/react-text-field/#basic-textfield feels right:

Screen.Recording.2024-09-11.at.20.12.12.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: field status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants