Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Field] Create new Field components #477

Merged
merged 108 commits into from
Aug 19, 2024
Merged

[Field] Create new Field components #477

merged 108 commits into from
Aug 19, 2024

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jul 15, 2024 •
edited by oliviertassinari
Loading

@mui-bot
Copy link

mui-bot commented Jul 15, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-477--base-ui.netlify.app/

Generated by 🚫 dangerJS against 2d7ede7

@atomiks atomiks changed the title [Field] Create new Field and Label components [Field] Create new Field components Jul 16, 2024
@atomiks atomiks marked this pull request as draft July 16, 2024 02:10
@atomiks atomiks marked this pull request as ready for review July 17, 2024 07:47
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 23, 2024
@michaldudak michaldudak mentioned this pull request Jul 25, 2024
Closed
1 task
michaldudak
michaldudak reviewed Jul 29, 2024
View reviewed changes
docs/data/base/components/field/field.md Outdated Show resolved Hide resolved
docs/data/base/components/field/UnstyledFieldAsync.tsx Outdated Show resolved Hide resolved
packages/mui-base/src/Field/Message/FieldMessage.types.tsx Outdated Show resolved Hide resolved
docs/data/base/components/field/field.md Outdated Show resolved Hide resolved
docs/data/base/components/fieldset/fieldset.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Aug 6, 2024
michaldudak
michaldudak reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try rebasing this on top of #532 and see if it helps with the failing tests.

packages/mui-base/src/Checkbox/Root/CheckboxRoot.tsx Outdated Show resolved Hide resolved
packages/mui-base/src/Field/Control/FieldControl.test.tsx Outdated Show resolved Hide resolved
@atomiks atomiks merged commit c51fb49 into mui:master Aug 19, 2024
18 of 19 checks passed
@oliviertassinari oliviertassinari added component: text input This is the name of the generic UI component, not the React module! component: field and removed component: field component: text input This is the name of the generic UI component, not the React module! labels Sep 5, 2024
@oliviertassinari oliviertassinari mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@colmtuite colmtuite colmtuite approved these changes

Assignees
No one assigned
Labels
component: field
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atomiks @mui-bot @colmtuite @michaldudak @oliviertassinari