Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC][Field] Form components - Field, Label, HelperText #134

Closed
wants to merge 20 commits into from
Closed

[POC][Field] Form components - Field, Label, HelperText #134

wants to merge 20 commits into from

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Feb 29, 2024 •
edited
Loading

Example:

<FormField name="shipping_country">
  <Label>Shipping Country</Label>
  <HelpText>
    We cannot ship cards to unsupported countries
  </HelpText>
  <Select defaultValue="AU">
    <Option value="AU">
      Australia
    </Option>
    <Option value="BE">
      Belgium
    </Option>
    <Option value="CA">
      Canada
    </Option>
  </Select>
</FormField>

Shaping doc: https://www.notion.so/mui-org/base-ui-Making-form-fields-with-the-composition-API-ab5a887191534a2fa6f2dc7e0f2a87c8?pvs=4

@mj12albert mj12albert added the proof of concept Studying and/or experimenting with a to be validated approach label Feb 29, 2024
@mj12albert mj12albert changed the title Poc/form field [POC][FormControl] Feb 29, 2024
@mj12albert mj12albert changed the title [POC][FormControl] [POC][FormField] Feb 29, 2024
@mj12albert mj12albert changed the title [POC][FormField] [POC][FormField] Form components Feb 29, 2024
@mj12albert mj12albert force-pushed the poc/form-field branch 3 times, most recently from eeadad4 to 4675df5 Compare March 6, 2024 08:44
@mj12albert mj12albert changed the title [POC][FormField] Form components [POC][Field] Form components - Field, Label, HelperText Mar 7, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 15, 2024
@michaldudak
Copy link
Member

michaldudak commented Jul 25, 2024 •
edited
Loading

@atomiks, @mj12albert, is this PR still relevant now that we have #477?

@mj12albert mj12albert closed this Aug 2, 2024
@mj12albert mj12albert deleted the poc/form-field branch October 25, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks Awaiting requested review from atomiks atomiks will be requested when the pull request is marked ready for review atomiks is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak will be requested when the pull request is marked ready for review michaldudak is a code owner

Assignees
No one assigned
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged proof of concept Studying and/or experimenting with a to be validated approach
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mj12albert @michaldudak