[core] Simplify isReactVersionAtLeast() #1047
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as mui/material-ui#43820
Off topic. I could see us creating an internal helper and exposing fit from Base UI, this duplication feels off:
reactMajor } from '@mui/internal-test-utils';
but the source use something different? Doesn't make much sense.A possible path:
isReactVersionAtLeast()
no need for an abstraction of:>=
.majorVersion
from@base-ui-components/internal/majorVersion
The value is then only about abstracting
parseInt(React.version, 10)
into something simpler.If we are worried about the coupling of Base UI / Material UI / MUI X (I don't understand this as I think it's a great thing, it forces Base UI to be anchored into its product purpose) but ok, we could replicate the same structure. I see no reason for this to be different.