Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avatar] Support cross origin in useImageLoadingStatus #1433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ISnackable
Copy link

Description

Add crossOrigin Support to useImageLoadingStatus Hook.

This PR adds crossOrigin support to the useImageLoadingStatus hook to handle images hosted on external domains that require specific crossOrigin settings (anonymous or use-credentials).

By including this option, we ensure broader compatibility with external image sources and resolve potential loading issues.

Note: radix-ui/primitives(https://github.com/radix-ui/primitives) has this exact issue and already has a PR radix-ui/primitives#3261. So here's a corresponding PR for Base UI 😊

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 719a5df
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67a62e23da473400087a166a
😎 Deploy Preview https://deploy-preview-1433--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant