-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Toolbar] POC with context checking API #1437
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Issues so far:
2/3 could possibly be worked around by not using Not sure if anything can be done about 1, it doesn't seem ideal to expose |
import { useToolbarRootContext, type ToolbarRootContext } from './ToolbarRootContext'; | ||
import type { ToolbarItemMetadata } from './ToolbarRoot'; | ||
|
||
function useCompositeButton(parameters: useCompositeButton.Parameters) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this is super rough right now, don't look too closely)
Going with the original API in #661 |
Demo: https://deploy-preview-1437--base-ui.netlify.app/experiments/toolbar/text-editor
Full source: https://github.com/mui/base-ui/blob/2eae6834348d70804ca94c93f97c04b2f4738adf/docs/src/app/(private)/experiments/toolbar/text-editor.tsx
Forked from #1349