[Tabs] Fix keyboard navigation involving disabled Tabs #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: tabs
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mj12albert
force-pushed
the
fix/disabled-tab-nav
branch
3 times, most recently
from
bd7dfb7 to
7dbdef8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mj12albert
force-pushed
the
fix/disabled-tab-nav
branch
from
7dbdef8 to
05c214f
Compare
mj12albert
force-pushed
the
fix/disabled-tab-nav
branch
from
9ddf851 to
2c50af8
Compare
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
michaldudak
reviewed
Feb 19, 2025
| @@ -94,6 +94,7 @@ const TabsList = React.forwardRef(function TabsList( | |||
| onHighlightedIndexChange={setHighlightedTabIndex} | |||
| onMapChange={setTabMap} | |||
| render={renderElement()} | |||
| disabledIndices={[]} | |||
There was a problem hiding this comment.
Do not recreate the array on each render.
| @@ -58,11 +58,15 @@ function useTabsTab(parameters: useTabsTab.Parameters): useTabsTab.ReturnValue { | |||
| return valueParam === selectedTabValue; | |||
| }, [index, selectedTabValue, valueParam]); | |||
|
|
|||
| // when activateOnFocus is `true`, ensure the active item in Composite's roving | |||
| // focus group matches the selected Tab | |||
| const selectedValueSyncedWithHighlightedTabIndexRef = React.useRef(false); | |||
There was a problem hiding this comment.
It's a mouthful :)
But too long is much better than too short, so let's leave it.
There was a problem hiding this comment.
this is all within a few lines so I shortened it by 12 chars 😅
isSelectionSyncedWithHighlightRef
michaldudak
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1442
Before: https://codesandbox.io/p/sandbox/tender-bassi-w74kv9
After: https://codesandbox.io/p/devbox/restless-framework-g3j43t?file=%2Fsrc%2FApp.tsx
Tabs are intentionally focusable when disabled, so it should be possible to move focus to disabled Tabs using the arrow keys. The disabled state should only disable tab activation.