Skip to content

Conversation

@michaldudak
Copy link
Member

After the introduction of the utils package, pr.pkg.new stopped working correctly due to stackblitz-labs/pkg.pr.new#389. The react package does not reference the preview version of the utils package.

This workaround removes the --pnpm flag and points pkg.pr.new CLI to the build output of individual packages.

@michaldudak michaldudak requested a review from a team July 18, 2025 08:30
@michaldudak michaldudak requested a review from atomiks as a code owner July 18, 2025 08:30
@michaldudak michaldudak added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Jul 18, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 18, 2025

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2322
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2322

commit: 9774e88

@mui-bot
Copy link

mui-bot commented Jul 18, 2025

Bundle size report

Bundle Parsed Size Gzip Size
@base-ui-components/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 9774e88

@netlify
Copy link

netlify bot commented Jul 18, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 9774e88
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/687a0643fbb6070007463dcd
😎 Deploy Preview https://deploy-preview-2322--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. I'll see if this can be abstracted to mui-public so that all repos don't require such kind of fixing individually.

@michaldudak michaldudak merged commit a2e10fa into mui:master Jul 18, 2025
22 checks passed
@michaldudak michaldudak deleted the fix-pkg-pr-new-builds branch July 18, 2025 08:37
@Janpot
Copy link
Member

Janpot commented Jul 18, 2025

atomiks pushed a commit to atomiks/base-ui that referenced this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants