Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove sources of old components we don't intend to support #474

Merged
merged 12 commits into from
Jul 25, 2024
Merged

[core] Remove sources of old components we don't intend to support #474

merged 12 commits into from
Jul 25, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jul 4, 2024 •
edited
Loading

Removed sources of the following legacy components and their hooks:

  • Badge - presentational component
  • Button (the hook remains as it's used internally)
  • CssAnimation - replaced by the new transitions API
  • CssTransition - replaced by the new transitions API
  • Input - native <input> should be used instead
  • Modal - built into the new Dialog
  • Popper - replaced by higher-level components (Dialog, Popover, etc.)

@mui-bot
Copy link

mui-bot commented Jul 4, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-474--base-ui.netlify.app/

Generated by 🚫 dangerJS against 7099a9f

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 24, 2024
@michaldudak michaldudak marked this pull request as ready for review July 25, 2024 07:37
@michaldudak
Copy link
Member Author

Not sure why the test-dev workflow isn't triggered. Looks like a GitHub hiccup, as I didn't change anything related. I'll try to merge it, and if it still fails, I'll work on a fix.

@michaldudak michaldudak merged commit 3ee8797 into mui:master Jul 25, 2024
15 checks passed
@michaldudak michaldudak deleted the remove-old-components branch July 25, 2024 09:56
@zannager zannager added the core Infrastructure work going on behind the scenes label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite colmtuite approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaldudak @mui-bot @colmtuite @atomiks @zannager