[test] Fix tests on Safari #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
michaldudak
force-pushed
the
safari-test-fix
branch
from
9e1e08a
to
79c498b
Compare
michaldudak
force-pushed
the
safari-test-fix
branch
from
fcd9c50
to
7a5327f
Compare
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
michaldudak
commented
Aug 27, 2024
| @@ -22,7 +21,7 @@ const browserStack = { | |||
| // Since we have limited resources on BrowserStack we often time out on PRs. | |||
| // However, BrowserStack rarely fails with a true-positive so we use it as a stop gap for release not merge. | |||
| // But always enable it locally since people usually have to explicitly have to expose their BrowserStack access key anyway. | |||
| enabled: !CI || !isPR || process.env.BROWSERSTACK_FORCE === 'true', | |||
| enabled: true, | |||
There was a problem hiding this comment.
I enabled Browserstack tests on PRs to verify if Safari doesn't fail. I'll revert this change after the PR is approved.
atomiks
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrowserStack tests consistently fail on Safari (and occasionally on other browsers) while running the code on an actual browser works well. I decided to skip running the problematic test and fix few other issues.