Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value as clippingAncestors to collisionBoundary prop #580

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add default value as clippingAncestors to collisionBoundary prop #580

merged 1 commit into from
Sep 10, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 3, 2024 •
edited
Loading

Docs says default value of collsionBoundary prop is clippingAncestors but it's not defined anywhere. This PR adds missing default values.

@mui-bot
Copy link

mui-bot commented Sep 3, 2024

Netlify deploy preview

https://deploy-preview-580--base-ui.netlify.app/

Generated by 🚫 dangerJS against a8dd6f9

michaldudak
michaldudak approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaldudak michaldudak merged commit 480e33d into mui:master Sep 10, 2024
18 of 19 checks passed
@zannager zannager added the docs Improvements or additions to the documentation label Sep 10, 2024
@michaldudak michaldudak added component: menu This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. and removed docs Improvements or additions to the documentation labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sai6855 @mui-bot @michaldudak @zannager