[useButton] Modernize implementation #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
the
component: button
Netlify deploy preview |
atomiks
reviewed
Sep 24, 2024
Comment on lines
178
to
181
| /** | ||
| * A ref to the component's root DOM element. | ||
| */ | ||
| rootRef: React.RefCallback<Element> | null; |
There was a problem hiding this comment.
This should be called buttonRef now. The root idea is confusing
atomiks
reviewed
Sep 30, 2024
Comment on lines
162
to
180
| /** | ||
| * The HTML element, e.g.'button', 'span' etc. | ||
| * @default '' | ||
| */ | ||
| rootElementName?: keyof HTMLElementTagNameMap; | ||
| } | ||
|
|
||
| export interface ReturnValue { | ||
| /** | ||
| * Resolver for the root slot's props. | ||
| * @param externalProps additional props for the root slot | ||
| * @returns props that should be spread on the root slot | ||
| */ | ||
| getRootProps: ( | ||
| externalProps?: React.ComponentPropsWithRef<any>, | ||
| ) => React.ComponentPropsWithRef<any>; | ||
| /** | ||
| * A ref to the component's root DOM element. | ||
| */ |
14 tasks
atomiks
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
activeandfocus-visiblepolyfillsCloses #47