Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix the test_types_next CI job #703

Merged
merged 3 commits into from
Oct 4, 2024
Merged

[test] Fix the test_types_next CI job #703

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4568c0e
[test] Fix the test_types_next CI job
michaldudak Oct 4, 2024
9ea81bc
Trigger tests
michaldudak Oct 4, 2024
82767a3
Revert pipeline trigger
michaldudak Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,14 +246,14 @@ jobs:
resource_class: 'medium+'
steps:
- checkout
- install_js:
react-version: << parameters.react-version >>
- run:
name: Resolve typescript version
command: |
pnpm add typescript@next -d -w
# log a patch for maintainers who want to check out this change
git --no-pager diff HEAD
- install_js:
react-version: << parameters.react-version >>
- run:
name: Tests TypeScript definitions
command: |
Expand All @@ -263,21 +263,18 @@ jobs:
set +e
pnpm typescript
exit 0

- restore_cache:
name: Restore generated declaration files
keys:
# We assume that the target branch is `next` and that declaration files are persisted in commit order.
# We assume that the target branch is `master` and that declaration files are persisted in commit order.
# "If there are multiple matches, the most recently generated cache will be used."
- typescript-declaration-files-next

- typescript-declaration-files-master
- run:
name: Diff declaration files
command: |
git add -f packages/mui-base/build || echo '/base declarations do not exist'
pnpm -r build:types
git --no-pager diff

- run:
name: Log defect declaration files
command: |
Expand Down