Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toggle][ToggleGroup] Create Toggle and ToggleGroup #763

Merged
merged 46 commits into from
Dec 3, 2024

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Oct 28, 2024

@mj12albert mj12albert added new feature New feature or request component: toggle button This is the name of the generic UI component, not the React module! labels Oct 28, 2024
@mui-bot
Copy link

mui-bot commented Oct 28, 2024

Netlify deploy preview

https://deploy-preview-763--base-ui.netlify.app/

Generated by 🚫 dangerJS against 5a051ba

@mj12albert mj12albert force-pushed the feat/toggle-button branch 4 times, most recently from 6c0fe92 to 6e04229 Compare October 28, 2024 17:06
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 30, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 30, 2024
@mj12albert mj12albert force-pushed the feat/toggle-button branch 5 times, most recently from 9bcba83 to 3a74374 Compare October 31, 2024 14:07
@mj12albert mj12albert changed the title [ToggleButton] Create ToggleButton [ToggleButton][ToggleButtonGroup] Create ToggleButton and ToggleButtonGroup Oct 31, 2024
@mj12albert mj12albert force-pushed the feat/toggle-button branch 2 times, most recently from 7cc24fd to b06a97d Compare October 31, 2024 15:17
@mj12albert mj12albert added the component: button group This is the name of the generic UI component, not the React module! label Oct 31, 2024
@mj12albert mj12albert force-pushed the feat/toggle-button branch 10 times, most recently from bcdd1cc to 7c449d8 Compare November 1, 2024 07:52
@mj12albert mj12albert changed the title [ToggleButton][ToggleButtonGroup] Create ToggleButton and ToggleButtonGroup [Toggle][ToggleGroup] Create Toggle and ToggleGroup Dec 2, 2024
@mj12albert mj12albert force-pushed the feat/toggle-button branch 3 times, most recently from 43b90cb to 2897708 Compare December 2, 2024 15:01
@mj12albert mj12albert removed the request for review from colmtuite December 3, 2024 09:22
@mj12albert mj12albert requested a review from colmtuite December 3, 2024 09:23
@colmtuite
Copy link
Contributor

  • Docs don't mention the disabled prop on ToggleGroup.
  • Missing orientation?
  • Missing loop?
  • ToggleGroup docs content not updated with recent changes (Anatomy etc.).

@mj12albert
Copy link
Member Author

  • Docs don't mention the disabled prop on ToggleGroup.
  • Missing orientation?
  • Missing loop?
  • ToggleGroup docs content not updated with recent changes (Anatomy etc.).

@colmtuite I double checked and the props are all here, also fixed the docs content (anatomy)

I think there is an issue on master right now causing the props table to not generate correctly, so they appear missing from the docs in the deploy preview, I'll investigate this separately

@mj12albert mj12albert merged commit 144f528 into mui:master Dec 3, 2024
23 checks passed
@mj12albert mj12albert deleted the feat/toggle-button branch December 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: toggle button This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ToggleButtonGroup] Implement ToggleButtonGroup [ToggleButton] Implement ToggleButton
6 participants