[Popover] Disable focus management when opened via hover #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atomiks
commented
Nov 22, 2024
atomiks
commented
- I have followed (at least) the PR section of the contributing guide.
atomiks
commented
Nov 22, 2024
| @@ -69,22 +68,21 @@ export function usePopoverRoot(params: usePopoverRoot.Parameters): usePopoverRoo | |||
| (nextOpen: boolean, event?: Event, reason?: OpenChangeReason) => { | |||
| onOpenChange(nextOpen, event, reason); | |||
| setOpenUnwrapped(nextOpen); | |||
| if (!keepMounted && !nextOpen) { | |||
There was a problem hiding this comment.
Need to check how setMounted(false) with this keepMounted check operates now for the other components with the hidden prop
There was a problem hiding this comment.
Looks like keepMounted was never passed to the hooks, hence it worked like keepMounted=false. I've removed the prop for Popover but it should be done for all components.
Netlify deploy preview |
|
It feels wrong that the popover closes on mouseout after an input inside it has been focused. Clicking on anything inside the popover should make it sticky |
|
@michaldudak that's a separate discussion as the previous focus management also worked like this |
michaldudak
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.