-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Mobile nav #881
[docs] Mobile nav #881
Conversation
Netlify deploy preview |
@vladmoroz It's exceptionally good overall 👏
|
Yeah I had used to close mobile menus when resizing to a larger viewport. I considered it here and decided that it's unwanted motion and it doesn't feel solid. As a user, if I did end up in this situation legitimately, I think I'd rather keep seeing the open menu. Switching context with a different page layout feels too tasking; it's easier to pick up where you left off and finish the navigation.
Do you feel the same about the main content separators? They use the same colour
I know your taste with animations, but if anything, I'd say it's already a bit too fast. It might feel a bit slow on desktop, but seems right or on the fast side on the actual device. Native iOS sheets that are about twice as short as this one transition about 30-50% slower. Also I hope you don't look at the actual
Will check. iirc
Will give a larger size a go |
Ok.
Yep, too high contrast for me.
I did most of my testing on my iPhone 12 mini. I checked a few more apps since and I'm finding a mixed bag of timings. Deliveroo iOS seems similar in duration to your animation. Perhaps it's fine.
Deliveroo iOS sheet links also seem the same size? Perhaps this is also a matter of taste + user demographic. |
@vladmoroz Bug:
|
@colmtuite yeah it's a bug in popups, there's a fix coming in #878 |
@colmtuite new Safari bug 🫠 RPReplay_Final1732796404.movWithout RPReplay_Final1732796382.movLooks like that's ruled out |
https://deploy-preview-881--base-ui.netlify.app/new/components/dialog