Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] Fix regression on disabling focus management on hover #888

Merged
merged 5 commits into from
Nov 29, 2024
Merged

[Popover] Fix regression on disabling focus management on hover #888

merged 5 commits into from
Nov 29, 2024

Conversation

michaldudak
Copy link
Member

#878 brought back the bug causing page scrolling after a hover-triggered Popover is closed.

@michaldudak michaldudak added bug 🐛 Something doesn't work component: popover The React component. labels Nov 28, 2024
@mui-bot
Copy link

mui-bot commented Nov 28, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-888--base-ui.netlify.app/

Generated by 🚫 dangerJS against 24d3022

@michaldudak michaldudak marked this pull request as ready for review November 28, 2024 11:27
@michaldudak michaldudak merged commit 5afdcd7 into mui:master Nov 29, 2024
23 checks passed
@michaldudak michaldudak deleted the fix-hoverable-popovers-focus branch November 29, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: popover The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @mui-bot @atomiks