Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Retain highlight while transitioning out #972

Merged
merged 10 commits into from
Dec 11, 2024
Merged

[Select] Retain highlight while transitioning out #972

merged 10 commits into from
Dec 11, 2024

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 6, 2024

Closes #965

@atomiks atomiks added the component: select This is the name of the generic UI component, not the React module! label Dec 6, 2024
@mui-bot
Copy link

mui-bot commented Dec 6, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-972--base-ui.netlify.app/

Generated by 🚫 dangerJS against 3d88261

@colmtuite colmtuite requested a review from vladmoroz December 9, 2024 20:14
@colmtuite colmtuite added this to the 1.0.0-alpha.1 release milestone Dec 9, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 9, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 11, 2024
mnajdova
mnajdova approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👌

@atomiks atomiks merged commit 961523e into mui:master Dec 11, 2024
23 checks passed
@atomiks atomiks deleted the fix/select-retain-highlight branch December 11, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

@vladmoroz vladmoroz Awaiting requested review from vladmoroz

Assignees

@atomiks atomiks

Labels
component: select This is the name of the generic UI component, not the React module!
Projects
Base UI
Status: Done
Milestone
1.0.0-alpha.1 release
Development

Successfully merging this pull request may close these issues.

[Select] Retain the highlight state when closing
4 participants
@atomiks @mui-bot @mnajdova @colmtuite