Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type compatibility issues with material-ui 4.9.0 #1465

Closed
mvestergaard opened this issue Jan 22, 2020 · 2 comments
Closed

Type compatibility issues with material-ui 4.9.0 #1465

mvestergaard opened this issue Jan 22, 2020 · 2 comments
Assignees

Comments

@mvestergaard
Copy link

Due to the changes made in mui/material-ui#19320 a type error occurs in pickers

node_modules/@material-ui/pickers/views/Clock/Clock.d.ts:4:48 - error TS2344: Type '(theme: Theme) => Record<"container" | "clock" | "squareMask" | "pin", CSSProperties | (() => CSSProperties)>' does not satisfy the constraint 'string | Record<any, CSSProperties | CreateCSSProperties<any> | ((props: any) => CreateCSSProperties<any>)> | StyleRulesCallback<...>'.
  Type '(theme: Theme) => Record<"container" | "clock" | "squareMask" | "pin", CSSProperties | (() => CSSProperties)>' is not assignable to type 'StyleRulesCallback<any, any, any>'.
    Type 'Record<"container" | "clock" | "squareMask" | "pin", CSSProperties | (() => CSSProperties)>' is not assignable to type 'Record<any, CSSProperties | CreateCSSProperties<any> | ((props: any) => CreateCSSProperties<any>)>'.
      Property 'container' is incompatible with index signature.
        Type 'CSSProperties | (() => CSSProperties)' is not assignable to type 'CSSProperties | CreateCSSProperties<any> | ((props: any) => CreateCSSProperties<any>)'.
          Type '() => CSSProperties' is not assignable to type 'CSSProperties | CreateCSSProperties<any> | ((props: any) => CreateCSSProperties<any>)'.
            Type '() => CSSProperties' is not assignable to type '(props: any) => CreateCSSProperties<any>'.

export interface ClockProps extends WithStyles<typeof styles> {
                                                 ~~~~~~~~~~~~~

Environment

Tech Version
@material-ui/pickers 3.2.9
material-ui 4.9.0
TypeScript 3.7.5
mvestergaard added a commit to mvestergaard/material-ui-pickers that referenced this issue Jan 23, 2020
This fixes some compatibility issues with material-ui 4.9.0
It should also be backwards compatible

Fixes mui#1465
mvestergaard added a commit to mvestergaard/material-ui-pickers that referenced this issue Jan 23, 2020
This fixes some compatibility issues with material-ui 4.9.0
It should also be backwards compatible

Fixes mui#1465
@OriginLive
Copy link

Hi, any eta on when this will be resolved?

@eps1lon eps1lon self-assigned this Jan 24, 2020
mvestergaard added a commit to mvestergaard/material-ui-pickers that referenced this issue Jan 24, 2020
…s some compatibility issues with material-ui 4.9.0It should also be backwards compatibleFixes mui#1465
@dmtrKovalenko
Copy link
Member

Released in 2.3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants