-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve renderInput props structure #1758
Comments
The only problem is that toolbar title must be the same as label (by material design spec) |
Interesting, I guess we need to keep the label then 👌 |
I have tried to do the change in the lab but faced this issue mui/material-ui#18289. What about we move in the same direction here? Should the helper text be really visible when the desktop popup/modal opens? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Having a closer look at #1751, I think that we have an opportunity to improve the API. Basically, I have been wondering about how to best structure the
props
object for the Autocomplete in the past: https://github.com/mui-org/material-ui/blob/05480c173f6a491760fdbf51552ff8bcc4beb7d2/packages/material-ui-lab/src/Autocomplete/Autocomplete.js#L408-L456.What about?
data-mui-test
from the spread options. This should be development only prop, and even then, we should aim to replace most, if not all of these attributes with a11y features. In our case, it seems thatkeyboard-date-input
isn't used. I believe we can remove it without much concerns :).onChange
,onFocus
,onBlur
,type
,value
,placeholder
intoinputProps
.label
, leave it to the userInputProps
to the root.This way, we would get a similar DX and a simpler customization API:
The text was updated successfully, but these errors were encountered: