-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix popup placement #18289
Merged
oliviertassinari
merged 2 commits into
mui:master
from
andreasheim:autocomplete-helpertext
Nov 11, 2019
Merged
[Autocomplete] Fix popup placement #18289
oliviertassinari
merged 2 commits into
mui:master
from
andreasheim:autocomplete-helpertext
Nov 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 0e0f17e...15908e9
|
andreasheim
changed the title
Autocomplete: Fix helperText showing through when dropdown is open
[Autocomplete] Fix helperText showing through when dropdown is open
Nov 10, 2019
oliviertassinari
added
the
component: autocomplete
This is the name of the generic UI component, not the React module!
label
Nov 10, 2019
oliviertassinari
force-pushed
the
autocomplete-helpertext
branch
from
November 10, 2019 11:53
2f609fa
to
15908e9
Compare
oliviertassinari
changed the title
[Autocomplete] Fix helperText showing through when dropdown is open
[Autocomplete] Fix popup placement
Nov 10, 2019
oliviertassinari
approved these changes
Nov 10, 2019
@andreasheim Thank you |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: autocomplete
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when adding a
helperText
to the TextInput provided to the<Autocomplete>
, it would show through like so:@oliviertassinari suggested moving the anchor el ref to InputProps.
This does seem to address the issue:
Breaking change
I added a helperText to the Tags.js example to test this: