-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for nested imports? #1934
Comments
I know that this works
|
@aamirafridi We don't support nested imports for the pickers repository. We might with mui/material-ui#19706. I think that the correct solution would be: import DateRangePicker, {
DesktopDateRangePicker,
MobileDateRangePicker,
} from "@material-ui/pickers/DateRangePicker"; The incentive so far for supporting it is that tree-shaking doesn't work in development, which can harm the DX. |
Ok thanks :) |
Keeping it open to signal that it's not fixed and incentive for more comments. |
oliviertassinari
changed the title
No Typescript error but JS errored
Support for nested imports?
Jun 24, 2020
oliviertassinari
changed the title
Support for nested imports?
Support for nested imports?
Jun 24, 2020
This was referenced Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using the Import like this for treeshaking
No TS error but JS errored
Cannot find module '@material-ui/pickers/DateRangePicker/DateRangePicker'
The text was updated successfully, but these errors were encountered: