[DatePicker] Add test for textbox aria-invalid #1955

PaulSavignano · 2020-07-04T15:18:03Z

Tests aria-invalid attribute on the DatePicker's input element when the locale is updated and the date becomes invalid through incorrect text input.
Add test test for Wrong value of isValid() when using DE #1895 (Fix/add locale to parse dmtrKovalenko/date-io#406)

vercel · 2020-07-04T15:18:06Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui-pickers/7j4y5wbne
✅ Preview: https://material-ui-pi-git-fork-paulsavignano-test-datepickertes-1e0c6f.mui-org.vercel.app

cypress · 2020-07-04T15:25:58Z

Test summary

78 • 0 • 3 • 0

Run details


Project	material-ui-pickers
Status	Passed
Commit	`cf31b5c`
Started	Jul 31, 2020 12:06 PM
Ended	Jul 31, 2020 12:08 PM
Duration	01:34 💡
OS	Linux Debian - 10.0
Browser	Chrome 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

dmtrKovalenko

Thanks, this test case is definitely nice to have. Added a couple of comments how to make tests more readable.

lib/src/__tests__/DatePickerTestingLib.test.tsx

oliviertassinari

Great start :)

lib/src/__tests__/DatePickerTestingLib.test.tsx

docs/pages/guides/upgrading-to-v3.mdx

lib/src/__tests__/DatePickerTestingLib.test.tsx

dmtrKovalenko · 2020-07-10T12:26:58Z

Am I the only who cannot see the changes of this PR?

PaulSavignano · 2020-07-11T14:10:39Z

@dmtrKovalenko, During a revert to an earlier commit my local git became out of sync and would not pull in changes from the next branch. I was unable to merge and ran a reset.

While running tests with luxon and moment the test for valid after invalid fails with locale de. I can look into this further if you'd like.

oliviertassinari

I have left a few comments, we are almost there :).

lib/src/__tests__/DatePickerTestingLib.test.tsx

lib/src/__tests__/test-utils.tsx

oliviertassinari · 2020-07-30T15:51:31Z

lib/package.json

@@ -60,7 +60,7 @@
    "test": "jest",
    "test:typescript": "yarn rimraf src/__tests__/dist && tsc -p src/__tests__/tsconfig.json",
    "test:date-fns": "UTILS=date-fns yarn test",
-    "test:dayjs": "UTILS=datejs yarn test",
+    "test:dayjs": "UTILS=dayjs yarn test",


@dmtrKovalenko Dayjs tests were running with date-fns

updated

dmtrKovalenko

Thanks for this awesome tests!

lib/src/__tests__/DatePickerTestingLib.test.tsx

vercel bot deployed to Preview July 4, 2020 15:18 View deployment

dmtrKovalenko previously requested changes Jul 4, 2020

View reviewed changes

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved

oliviertassinari reviewed Jul 4, 2020

View reviewed changes

vercel bot deployed to Preview July 4, 2020 17:03 View deployment

oliviertassinari mentioned this pull request Jul 6, 2020

[RFC] Replace MaterialUiPickersDate type with DateType #1962

Closed

vercel bot deployed to Preview July 6, 2020 15:42 View deployment

oliviertassinari reviewed Jul 6, 2020

View reviewed changes

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview July 7, 2020 15:05 View deployment

vercel bot deployed to Preview July 7, 2020 15:12 View deployment

vercel bot deployed to Preview July 7, 2020 15:23 View deployment

vercel bot deployed to Preview July 7, 2020 15:34 View deployment

oliviertassinari reviewed Jul 7, 2020

View reviewed changes

docs/pages/guides/upgrading-to-v3.mdx Outdated Show resolved Hide resolved

oliviertassinari reviewed Jul 7, 2020

View reviewed changes

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved

vercel bot temporarily deployed to Preview July 7, 2020 16:22 Inactive

vercel bot deployed to Preview July 7, 2020 16:22 View deployment

vercel bot deployed to Preview July 8, 2020 23:44 View deployment

PaulSavignano force-pushed the test/DatePickerTestingLib branch from 63cc2d5 to 295bfa0 Compare July 8, 2020 23:58

vercel bot deployed to Preview July 8, 2020 23:58 View deployment

vercel bot deployed to Preview July 11, 2020 14:03 View deployment

vercel bot deployed to Preview July 11, 2020 14:31 View deployment

vercel bot deployed to Preview July 11, 2020 14:44 View deployment

oliviertassinari reviewed Jul 11, 2020

View reviewed changes

oliviertassinari added the test label Jul 11, 2020

vercel bot deployed to Preview July 11, 2020 15:10 View deployment

vercel bot requested a deployment to Preview July 12, 2020 18:45 Pending

vercel bot deployed to Preview July 12, 2020 18:48 View deployment

oliviertassinari force-pushed the test/DatePickerTestingLib branch from 60429fc to 571a2a5 Compare July 30, 2020 15:06

vercel bot deployed to Preview July 30, 2020 15:06 View deployment

oliviertassinari changed the title ~~test: add tests for locale updates~~ [DatePicker] Add test for textbox aria-invalid Jul 30, 2020

oliviertassinari added the component: DatePicker label Jul 30, 2020

vercel bot temporarily deployed to Preview July 30, 2020 15:10 Inactive

oliviertassinari force-pushed the test/DatePickerTestingLib branch from 5ff363b to 717ffd3 Compare July 30, 2020 15:11

add dayjs in the CI

667397e

vercel bot temporarily deployed to Preview July 30, 2020 15:11 Inactive

oliviertassinari force-pushed the test/DatePickerTestingLib branch from 717ffd3 to 667397e Compare July 30, 2020 15:11

vercel bot temporarily deployed to Preview July 30, 2020 15:12 Inactive

fix rebase

2be6294

vercel bot deployed to Preview July 30, 2020 15:18 View deployment

wrong name

7ac890a

vercel bot deployed to Preview July 30, 2020 15:34 View deployment

Skip tests that fail with dayjs

5d0b3e4

vercel bot deployed to Preview July 30, 2020 15:46 View deployment

oliviertassinari reviewed Jul 30, 2020

View reviewed changes

vercel bot temporarily deployed to Preview July 30, 2020 16:41 Inactive

oliviertassinari force-pushed the test/DatePickerTestingLib branch from 28b8469 to 55976a5 Compare July 30, 2020 16:41

vercel bot deployed to Preview July 30, 2020 16:41 View deployment

oops, too level describe convention wasn't applied

f109d6f

oliviertassinari force-pushed the test/DatePickerTestingLib branch from 55976a5 to f109d6f Compare July 30, 2020 16:50

vercel bot deployed to Preview July 30, 2020 16:50 View deployment

oliviertassinari requested a review from dmtrKovalenko July 30, 2020 16:59

oliviertassinari approved these changes Jul 30, 2020

View reviewed changes

dmtrKovalenko reviewed Jul 31, 2020

View reviewed changes

lib/src/__tests__/DatePickerTestingLib.test.tsx Outdated Show resolved Hide resolved

Dmitriy review

cf31b5c

vercel bot deployed to Preview July 31, 2020 12:03 View deployment

oliviertassinari merged commit ff33683 into mui:next Jul 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DatePicker] Add test for textbox aria-invalid #1955

[DatePicker] Add test for textbox aria-invalid #1955

PaulSavignano commented Jul 4, 2020 •

edited by oliviertassinari

Loading

vercel bot commented Jul 4, 2020 •

edited

Loading

cypress bot commented Jul 4, 2020 •

edited

Loading

dmtrKovalenko left a comment

oliviertassinari left a comment

dmtrKovalenko commented Jul 10, 2020

PaulSavignano commented Jul 11, 2020

oliviertassinari left a comment

oliviertassinari Jul 30, 2020

dmtrKovalenko left a comment

[DatePicker] Add test for textbox aria-invalid #1955

[DatePicker] Add test for textbox aria-invalid #1955

Conversation

PaulSavignano commented Jul 4, 2020 • edited by oliviertassinari Loading

vercel bot commented Jul 4, 2020 • edited Loading

cypress bot commented Jul 4, 2020 • edited Loading

Test summary

Run details

dmtrKovalenko left a comment

Choose a reason for hiding this comment

oliviertassinari left a comment

Choose a reason for hiding this comment

dmtrKovalenko commented Jul 10, 2020

PaulSavignano commented Jul 11, 2020

oliviertassinari left a comment

Choose a reason for hiding this comment

oliviertassinari Jul 30, 2020

Choose a reason for hiding this comment

dmtrKovalenko left a comment

Choose a reason for hiding this comment

PaulSavignano commented Jul 4, 2020 •

edited by oliviertassinari

Loading

vercel bot commented Jul 4, 2020 •

edited

Loading

cypress bot commented Jul 4, 2020 •

edited

Loading