Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #2034

Merged
merged 2 commits into from
Jul 26, 2020
Merged

[core] Batch small changes #2034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49b761a
[docs] TypeScript over alternative wordings
oliviertassinari Jul 25, 2020
913f6b2
[docs] Remove dead images
oliviertassinari Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ jobs:
- attach_workspace:
at: .
- run:
name: Typescript
name: TypeScript
command: yarn workspaces run build:typescript
- run:
name: Run typescript tests
name: Run TypeScript tests
command: yarn workspace @material-ui/pickers run test:typescript
- run:
name: Build and analyze bundlesize
Expand Down
6 changes: 0 additions & 6 deletions docs/assets/mui-logo.svg
View file
Open in desktop

This file was deleted.

Binary file removed docs/assets/pickers-logo.png
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion docs/pages/guides/css-overrides.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Pickers will also leverage `spacing` from the material-ui's theme

<Example source={CssThemeSpacing} />

#### Typescript
#### TypeScript

For TypeScript users it's also required to extend default material-ui theme typings with pickers controls.
This will also autocomplete classnames.
Expand Down
4 changes: 2 additions & 2 deletions docs/pages/guides/upgrading-to-v3.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ And it is still possible to fully customize mask, checkout [this](/api/timepicke
`ref` approach to customize open/close state was replaced with `open` props and `onClose`, `onOpen` callbacks.
Check out the [new example](/guides/controlling-programmatically)

#### 🛡 Typescript
#### 🛡 TypeScript

We are working hard to make this library perfectly Typescript compatible.
We are working hard to make this library perfectly TypeScript compatible.
And from `v3` and on, date type in such props like `onChange`, `value` will automatically be inferred from the `@date-io` package you used.
So less `any` from our side :)

Expand Down