Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#837] Export consumer component #838

Merged
merged 1 commit into from
Jan 7, 2019
Merged

[#837] Export consumer component #838

merged 1 commit into from
Jan 7, 2019

Conversation

skoging
Copy link
Contributor

@skoging skoging commented Jan 7, 2019

This PR closes #837

Description

Export the MuiPickersContextConsumer used internally.

@dmtrKovalenko dmtrKovalenko self-requested a review January 7, 2019 12:39
dmtrKovalenko
dmtrKovalenko approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmtrKovalenko dmtrKovalenko changed the title Export consumer component [#837] Export consumer component Jan 7, 2019
@dmtrKovalenko
Copy link
Member

I am wondering where is travis build...
Thats strange a lot

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@516c115). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #838   +/-   ##
==========================================
  Coverage           ?   92.67%           
==========================================
  Files              ?       40           
  Lines              ?     1338           
  Branches           ?      168           
==========================================
  Hits               ?     1240           
  Misses             ?       71           
  Partials           ?       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516c115...8f54c64. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit 34c4387 into mui:develop Jan 7, 2019
@skoging skoging deleted the patch-2 branch January 8, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmtrKovalenko dmtrKovalenko dmtrKovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skoging @dmtrKovalenko