[TextField] removed JSX.Element type from FormHelperText component prop

mui · Apr 14, 2020 · 0a9d765 · 0a9d765
1 parent 33a2311
commit 0a9d765
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/material-ui/src/TextField/TextField.d.ts b/packages/material-ui/src/TextField/TextField.d.ts
@@ -48,10 +48,7 @@ export interface BaseTextFieldProps
   /**
    * Props applied to the [`FormHelperText`](/api/form-helper-text/) element.
    */
-  FormHelperTextProps?: FormHelperTextProps<
-    React.ElementType,
-    { component: React.ElementType | JSX.Element }
-  >;
+  FormHelperTextProps?: FormHelperTextProps<React.ElementType, { component: React.ElementType }>;
   /**
    * If `true`, the input will take up the full width of its container.
    */

diff --git a/packages/material-ui/src/TextField/TextField.spec.tsx b/packages/material-ui/src/TextField/TextField.spec.tsx
@@ -70,8 +70,13 @@ function FocusHandlerTest() {
 
 function createElementTextFieldTest() {
   // $ExpectError
-  const stringParam = <TextField FormHelperTextProps={{ component: 'some-wrong-element' }} />;
+  const wrongElementType = <TextField FormHelperTextProps={{ component: 'some-wrong-element' }} />;
 
   // $ExpectError
   const numberParam = <TextField FormHelperTextProps={{ component: 1234 }} />;
+
+  // $ExpectError
+  const jsxParam = <TextField FormHelperTextProps={{ component: <div /> }} />;
+
+  const validElementType = <TextField FormHelperTextProps={{ component: 'div' }} />;
 }