Skip to content

Commit

Permalink
[lab] Depend on @babel/runtime. (#12470)
Browse files Browse the repository at this point in the history
@babel/runtime will also be installed by the peerDependency on @material-ui/core, but it might also
be installed by some other module or by the consuming app. That means the @babel/runtime that will
actually be resolved by @material-ui/lab is not guaranteed to be the same as the one resolved by
core, without an explicit dependency.

In particular, I was installing @babel/runtime@7.0.0-rc.1 in my app, which has different file paths
from beta.42, causing imports of @babel/runtime from @material-ui/lab to fail.

This patch ensures a compatible version of the runtime is always used.
  • Loading branch information
goto-bus-stop authored and oliviertassinari committed Aug 10, 2018
1 parent 8610f87 commit 26c904f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/material-ui-lab/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
"react": "^16.3.0",
"react-dom": "^16.3.0"
},
"dependencies": {},
"dependencies": {
"@babel/runtime": "7.0.0-beta.42"
},
"devDependencies": {},
"sideEffects": false,
"publishConfig": {
Expand Down

0 comments on commit 26c904f

Please sign in to comment.