[core] Prefer other over rest

packages/material-ui-lab/src/TreeView/descendants.js

@@ -129,14 +129,14 @@ export function DescendantProvider(props) {
 
  const [items, set] = React.useState([]);
 
- const registerDescendant = React.useCallback(({ element, ...rest }) => {
+ const registerDescendant = React.useCallback(({ element, ...other }) => {
  set((oldItems) => {
  let newItems;
  if (oldItems.length === 0) {
  // If there are no items, register at index 0 and bail.
  return [
  {
- ...rest,
+ ...other,
  element,
  index: 0,
  },
@@ -163,7 +163,7 @@ export function DescendantProvider(props) {
  // elements come or go from our component.
 
  const newItem = {
- ...rest,
+ ...other,
  element,
  index,
  };

packages/material-ui-lab/src/internal/pickers/wrappers/makeWrapperComponent.tsx

@@ -29,7 +29,6 @@ export function makeWrapperComponent<TWrapper extends SomeWrapper = any>(
  const {
  disableCloseOnSelect,
  cancelText,
- children,
  clearable,
  clearText,
  DateInputProps,
@@ -46,7 +45,7 @@ export function makeWrapperComponent<TWrapper extends SomeWrapper = any>(
  todayText,
  value,
  wrapperProps,
- ...restPropsForTextField
+ ...other
  } = props;
 
  const TypedWrapper = Wrapper as SomeWrapper;
@@ -65,10 +64,8 @@ export function makeWrapperComponent<TWrapper extends SomeWrapper = any>(
  PureDateInputComponent={PureDateInputComponent}
  displayStaticWrapperAs={displayStaticWrapperAs}
  {...wrapperProps}
- {...restPropsForTextField}
- >
- {children}
- </TypedWrapper>
+ {...other}
+ />
  );
  }
 

packages/material-ui-styles/src/propsToClassKey/propsToClassKey.js

@@ -19,11 +19,11 @@ function isEmpty(string) {
  * @param {object} props - the properties for which the classKey should be created
  */
 export default function propsToClassKey(props) {
- const { variant, ...rest } = props;
+ const { variant, ...other } = props;
 
  let classKey = variant || '';
 
- Object.keys(rest)
+ Object.keys(other)
  .sort()
  .forEach((key) => {
  if (key === 'color') {

packages/material-ui-unstyled/src/SliderUnstyled/SliderUnstyled.test.js

@@ -26,10 +26,10 @@ describe('<SliderUnstyled />', () => {
  let theme = null;
 
  const Root = React.forwardRef(
- ({ styleProps: stylePropsProp, theme: themeProp, ...rest }, ref) => {
+ ({ styleProps: stylePropsProp, theme: themeProp, ...other }, ref) => {
  styleProps = stylePropsProp;
  theme = themeProp;
- return <span ref={ref} {...rest} />;
+ return <span ref={ref} {...other} />;
  },
  );
 

packages/material-ui/src/Box/Box.spec.tsx

@@ -6,8 +6,8 @@ interface TestProps {
 }
 
 function Test(props: TestProps) {
- const { test, ...rest } = props;
- return <span {...rest}>{test}</span>;
+ const { test, ...other } = props;
+ return <span {...other}>{test}</span>;
 }
 
 function ResponsiveTest() {

packages/material-ui/src/styles/experimentalStyled.js

@@ -69,10 +69,10 @@ const experimentalStyled = (tag, options, muiOptions = {}) => {
  const expressionsWithDefaultTheme = expressions
  ? expressions.map((stylesArg) => {
  return typeof stylesArg === 'function'
- ? ({ theme: themeInput, ...rest }) => {
+ ? ({ theme: themeInput, ...oter }) => {
  return stylesArg({
  theme: isEmpty(themeInput) ? defaultTheme : themeInput,
- ...rest,
+ ...oter,
  });
  }
  : stylesArg;

packages/typescript-to-proptypes/test/unused-prop/input.tsx

@@ -7,10 +7,10 @@ type Props = {
 };
 
 export default function Foo(props: Props) {
- const { foo, ...rest } = props;
+ const { foo, ...other } = props;
 
  return (
- <div className={props.bar} {...rest}>
+ <div className={props.bar} {...other}>
  {foo}
  </div>
  );

packages/typescript-to-proptypes/test/unused-prop/output.js

@@ -1,9 +1,9 @@
 import * as React from 'react';
 import PropTypes from 'prop-types';
 function Foo(props) {
- const { foo, ...rest } = props;
+ const { foo, ...other } = props;
  return (
- <div className={props.bar} {...rest}>
+ <div className={props.bar} {...other}>
  {foo}
  </div>
  );