[Autocomplete] Only trigger onInputChange when the value changes (#18571

)
mui · Nov 26, 2019 · 73a599a · 73a599a
1 parent 4fc3f45
commit 73a599a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/packages/material-ui-lab/src/Autocomplete/Autocomplete.test.js b/packages/material-ui-lab/src/Autocomplete/Autocomplete.test.js
@@ -650,11 +650,10 @@ describe('<Autocomplete />', () => {
       const { getByRole } = render(<MyComponent />);
 
       const textbox = getByRole('textbox');
-      expect(handleChange.callCount).to.equal(1);
-      expect(handleChange.args[0][0]).to.equal('');
+      expect(handleChange.callCount).to.equal(0);
       fireEvent.change(textbox, { target: { value: 'a' } });
-      expect(handleChange.callCount).to.equal(2);
-      expect(handleChange.args[1][0]).to.equal('a');
+      expect(handleChange.callCount).to.equal(1);
+      expect(handleChange.args[0][0]).to.equal('a');
       expect(textbox.value).to.equal('');
     });
   });

diff --git a/packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js b/packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js
@@ -210,6 +210,10 @@ export default function useAutocomplete(props) {
       newInputValue = typeof optionLabel === 'string' ? optionLabel : '';
     }
 
+    if (inputValue === newInputValue) {
+      return;
+    }
+
     setInputValue(newInputValue);
 
     if (onInputChange) {
@@ -635,6 +639,10 @@ export default function useAutocomplete(props) {
       handleOpen(event);
     }
 
+    if (inputValue === newValue) {
+      return;
+    }
+
     setInputValue(newValue);
 
     if (onInputChange) {