[test] Conditional tests (#12191)

mui · Jul 18, 2018 · 77c48ca · 77c48ca
1 parent 77a2d77
commit 77c48ca
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 35 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -64,6 +64,37 @@ jobs:
  - run:
  name: Coverage
  command: bash <(curl -s https://codecov.io/bash)
+ test_material-ui-x:
+ <<: *defaults
+ steps:
+ - *restore_repo
+ - run:
+ name: material-ui-icons
+ command: |
+ if [[ ((`git diff --raw master | grep packages/material-ui-icons` > 0))]]; then
+ echo "changes, let's run the tests"
+ cd packages/material-ui-icons && yarn test
+ else
+ echo "no changes "
+ fi
+ - run:
+ name: material-ui-codemod
+ command: |
+ if [[ ((`git diff --raw master | grep packages/material-ui-codemod` > 0))]]; then
+ echo "changes, let's run the tests"
+ cd packages/material-ui-codemod && yarn test
+ else
+ echo "no changes "
+ fi
+ - run:
+ name: eslint-plugin-material-ui
+ command: |
+ if [[ ((`git diff --raw master | grep packages/eslint-plugin-material-ui` > 0))]]; then
+ echo "changes, let's run the tests"
+ cd packages/eslint-plugin-material-ui && yarn test
+ else
+ echo "no changes "
+ fi
  test_build:
  <<: *defaults
  # This isn't user facing code.
@@ -118,6 +149,9 @@ workflows:
  - test_unit:
  requires:
  - checkout
+ - test_material-ui-x:
+ requires:
+ - checkout
  - test_browser:
  requires:
  - checkout
@@ -126,6 +160,7 @@ workflows:
  - checkout
  - test_regressions:
  requires:
+ - test_material-ui-x
  - test_unit
  - test_browser
  - test_build
diff --git a/docs/src/pages/style/icons/SvgMaterialIconsAll.js b/docs/src/pages/style/icons/SvgMaterialIconsAll.js
@@ -1,35 +1,21 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import { withStyles } from '@material-ui/core/styles';
+// import React from 'react';
 
-const requireIcons = require.context('../../../../../packages/material-ui-icons/src', true, /js$/);
+// const requireIcons = require.context(
+// '../../../../../packages/material-ui-icons/src', true, /js$/);
 
-const styles = theme => ({
- root: {
- color: theme.palette.text.primary,
- maxHeight: 300,
- overflow: 'auto',
- },
-});
+// function SvgMaterialIconsAll() {
+// return (
+//  <div>
+//  {requireIcons.keys().map(key => {
+//  if (key === './index.js' || key === './utils/createSvgIcon.js') {
+// return null;
+// }
 
-function SvgMaterialIconsAll(props) {
- const { classes } = props;
- return (
- <div className={classes.root}>
- {requireIcons.keys().map(key => {
- if (key === './index.js' || key === './utils/createSvgIcon.js') {
- return null;
- }
+// const Icon = requireIcons(key).default;
+// return <Icon key={key} />;
+// })}
+// </div>
+// );
+// }
 
- const Icon = requireIcons(key).default;
- return <Icon key={key} />;
- })}
- </div>
- );
-}
-
-SvgMaterialIconsAll.propTypes = {
- classes: PropTypes.object.isRequired,
-};
-
-export default withStyles(styles)(SvgMaterialIconsAll);
+// export default withStyles(styles)(SvgMaterialIconsAll);
diff --git a/test/regressions/index.js b/test/regressions/index.js
@@ -33,17 +33,17 @@ const blacklistSuite = [
 
  // Useless
  'docs-', // Home
- 'docs-versions',
+ 'docs-discover-more-showcase',
  'docs-guides',
  'docs-premium-themes',
- 'docs-discover-more-showcase',
  'docs-style-color', // non important demo
+ 'docs-versions',
 ];
 
 const blacklistFilename = [
- 'docs-getting-started-usage/Usage.png', // codesandbox iframe
  'docs-demos-drawers/tileData.png', // no component
  'docs-demos-grid-list/tileData.png', // no component
+ 'docs-getting-started-usage/Usage.png', // codesandbox iframe
 ];
 
 // Also use some of the demos to avoid code duplication.
@@ -104,8 +104,13 @@ tests.forEach(test => {
  suite = vrtest.createSuite(test.suite);
  }
 
+ const TestCase = test.case;
+
+ if (!TestCase) {
+ return;
+ }
+
  suite.createTest(test.name, () => {
- const TestCase = test.case;
  ReactDOM.render(
  <TestViewer>
  <TestCase />