Convert async IIFE into promise-chain

mui · Oct 11, 2020 · a3a0b3d · a3a0b3d
1 parent 23684a7
commit a3a0b3d
Showing 1 changed file with 24 additions and 30 deletions.
diff --git a/docs/src/modules/components/Notifications.js b/docs/src/modules/components/Notifications.js
@@ -18,12 +18,6 @@ import Divider from '@material-ui/core/Divider';
 import { getCookie } from 'docs/src/modules/utils/helpers';
 import { ACTION_TYPES } from 'docs/src/modules/constants';
 
-function sleep(delay) {
-  return new Promise((resolve) => {
-    setTimeout(resolve, delay);
-  });
-}
-
 const useStyles = makeStyles((theme) => ({
   paper: {
     transformOrigin: 'top right',
@@ -96,33 +90,33 @@ export default function Notifications() {
       return undefined;
     }
 
-    (async () => {
-      await sleep(1500); // Soften the pressure on the main thread.
-      let newMessages;
-      try {
-        const result = await fetch(
-          'https://raw.githubusercontent.com/mui-org/material-ui/master/docs/notifications.json',
-        );
-        newMessages = await result.json();
-      } catch (err) {
-        // Swallow the exceptions, e.g. rate limit
-      }
-
-      if (active) {
-        const seen = getCookie('lastSeenNotification');
-        const lastSeenNotification = seen === '' ? 0 : parseInt(seen, 10);
-
-        dispatch({
-          type: ACTION_TYPES.NOTIFICATIONS_CHANGE,
-          payload: {
-            messages: newMessages || [],
-            lastSeen: lastSeenNotification,
-          },
+    // Soften the pressure on the main thread.
+    const timeout = setTimeout(() => {
+      fetch('https://raw.githubusercontent.com/mui-org/material-ui/master/docs/notifications.json')
+        .then((response) => {
+          return response.json();
+        })
+        .catch(() => {
+          // Swallow the exceptions, e.g. rate limit
+          return [];
+        })
+        .then((newMessages) => {
+          if (active) {
+            const seen = getCookie('lastSeenNotification');
+            const lastSeenNotification = seen === '' ? 0 : parseInt(seen, 10);
+            dispatch({
+              type: ACTION_TYPES.NOTIFICATIONS_CHANGE,
+              payload: {
+                messages: newMessages || [],
+                lastSeen: lastSeenNotification,
+              },
+            });
+          }
         });
-      }
-    })();
+    }, 1500);
 
     return () => {
+      clearTimeout(timeout);
       active = false;
     };
   }, []);