[Dialog] Fix TypeScript type for children (#20450)

mui · Apr 7, 2020 · a685203 · a685203
1 parent e751e90
commit a685203
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/material-ui/src/Dialog/Dialog.d.ts b/packages/material-ui/src/Dialog/Dialog.d.ts
@@ -17,7 +17,7 @@ export interface DialogProps
   /**
    * Dialog children, usually the included sub-components.
    */
-  children: React.ReactNode;
+  children?: React.ReactNode;
   /**
    * If `true`, clicking the backdrop will not fire the `onClose` callback.
    */

diff --git a/packages/material-ui/src/Dialog/Dialog.spec.tsx b/packages/material-ui/src/Dialog/Dialog.spec.tsx
@@ -0,0 +1,6 @@
+import * as React from 'react';
+import { Dialog } from '@material-ui/core';
+
+function optionalChildrenTest() {
+  <Dialog open />;
+}